Skip to content

move current namespace logic to config #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

move current namespace logic to config #675

wants to merge 1 commit into from

Conversation

KPostOffice
Copy link
Contributor

What changes have been made

I was running into some issues testing locally without specifying a namespace. I realized we could default early and make the error much clearer

Verification steps

Use the codeflare_sdk in a jupyter nb locally and don't specify namespace in your cluster configuration

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@KPostOffice
move current namespace logic to config
5ff9723 
Signed-off-by: Kevin <kpostlet@redhat.com>
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from kpostoffice. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ygnas Ygnas added test-ui-notebooks Run PR check to verify UI notebooks and removed test-ui-notebooks Run PR check to verify UI notebooks labels Sep 20, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Bobbins228
Bobbins228 suggested changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Kevin this looks really good. Is it cool if you update this to work with the refactored project?

Perhaps get_current_namespace should live in kube_api_helpers WDYT?

@Bobbins228
Copy link
Contributor

Perhaps kube_api_helpers doesnt work as there could be a circular import.
What would you think of a utils file in the utils module for helper functions like this?

I say this because as we add more modules e.g. KFT Training Client we would probably prefer common functions like this to live there? WDYT?

@KPostOffice
Copy link
Contributor Author

I'll take a look at finding a better place for this. A util file definitely makes more sense than auth.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bobbins228 Bobbins228 Bobbins228 requested changes

@Fiona-Waters Fiona-Waters Awaiting requested review from Fiona-Waters

@franciscojavierarceo franciscojavierarceo Awaiting requested review from franciscojavierarceo

Assignees

@Bobbins228 Bobbins228

Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KPostOffice @openshift-merge-robot @Bobbins228 @Ygnas